Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add topo to extra #1261

Merged
merged 6 commits into from
Mar 4, 2024
Merged

add topo to extra #1261

merged 6 commits into from
Mar 4, 2024

Conversation

valer1435
Copy link
Collaborator

Moved ripser to extra-dependencies

Copy link

docu-mentor bot commented Mar 1, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

@pep8speaks
Copy link

pep8speaks commented Mar 1, 2024

Hello @valer1435! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-01 08:19:26 UTC

Copy link
Contributor

github-actions bot commented Mar 1, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

add extra dependencies in unit test config
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.85%. Comparing base (c53881a) to head (2c4e25e).
Report is 1 commits behind head on master.

Files Patch % Lines
...edot/core/repository/operation_types_repository.py 50.00% 6 Missing ⚠️
...erations/topological/fast_topological_extractor.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1261      +/-   ##
==========================================
+ Coverage   79.82%   79.85%   +0.02%     
==========================================
  Files         150      146       -4     
  Lines       10322    10028     -294     
==========================================
- Hits         8240     8008     -232     
+ Misses       2082     2020      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valer1435 valer1435 merged commit 3c2c028 into master Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants